Skip to content

feat: add overrideAffected to flag metadata - #45

Merged
kinyoklion merged 2 commits into
mainfrom
devin/1794241273-ruby-override-affected
Nov 16, 2026
Merged

kinyoklion merged 2 commits into
mainfrom
devin/1794241273-ruby-override-affected

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Describe the solution you've provided

ResolutionDetailsConverter now sets overrideAffected: true in flag metadata when EvaluationReason#override_affected is true, and omits it otherwise (same as inExperiment, and as js-core's translateResult.ts). The launchdarkly-server-sdk dependency moves from ~> 8.19 to ~> 8.20, the first release with override_affected. The README flag-metadata table and feature matrix list the new key.

Tests cover override-affected true, false, unmarked reasons and an override-affected error evaluation. bundle exec rspec (78 examples, 0 failures) and rubocop pass locally on Ruby 3.4.7.

Describe alternatives you've considered

A respond_to?(:override_affected) guard that keeps the 8.19 floor (the approach in #44). Raising the floor is simpler, stays within the 8.x major and avoids a dead code path.

Additional context

None.


OpenFeature Maintainer opened this PR for Ryan

Implemented in session Add overrideAffected metadata to Ruby provider
Review with Devin · Open in Devin Desktop



Devin Review

SDK-3580


Note

Overview
Adds OpenFeature flag metadata support for LaunchDarkly override evaluations by surfacing overrideAffected: true when EvaluationReason#override_affected is set, and omitting the key otherwise (same pattern as inExperiment).

ResolutionDetailsConverter gains the overrideAffected metadata key; the launchdarkly-server-sdk runtime floor moves from ~> 8.19 to ~> 8.20 so override_affected is always available. README feature matrix and flag-metadata table document the new key; specs cover positive, false, absent, and error-with-override cases.

Reviewed by Cursor Bugbot for commit 461bd56. Bugbot is set up for automated code reviews on this repo. Configure here.

devin-ai-integration Bot and others added 2 commits November 9, 2026 16:22
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Co-Authored-By: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@kinyoklion
kinyoklion marked this pull request as ready for review November 12, 2026 23:20
@kinyoklion
kinyoklion requested a review from a team as a code owner November 12, 2026 23:20
@kinyoklion
kinyoklion merged commit 8ae500c into main Nov 16, 2026
15 checks passed
@kinyoklion
kinyoklion deleted the devin/1794241273-ruby-override-affected branch November 16, 2026 22:14
kinyoklion pushed a commit that referenced this pull request Nov 18, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.4.0](0.3.1...0.4.0)
(2026-11-17)


### Features

* add overrideAffected to flag metadata
([#45](#45))
([8ae500c](8ae500c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants